Re: [atomic-devel] [PATCH] docker-host: add python3-gobject-base and runc

[Giuseppe Scrivano <gscrivan redhat com>]

Hi Colin,

Colin Walters <walters verbum org> writes:

> Hi,
>
> On Sat, Apr 9, 2016, at 05:43 AM, Giuseppe Scrivano wrote:
>
>> is it fine to apply this patch now?
>
> The dependencies will come in automatically via the new `atomic` rpm right?
>
> The way I think of this is that things listed in the manifest are things
> that define the system - i.e. they're dependencies of things like the Ansible
> installer or other user code.  Rather than things that happen to be transitive
> dependencies.
>
> Of the two, runc seems more like a "system definition" component, whereas
> python3-gobject-base seems more like a dependency that happens to come
> along.
>
> So we could add runc now under the theory that projects other than projectatomic/atomic
> would use it, then have pygobject3-base pulled in by atomic.  WDYT?

yes right, that is definitely a better place to add this dependency.

I've attached the modified patch which adds only `runc`.

Regards,
Giuseppe

>From 5c2f6a7c8891f59e9c447c557f130416a352f2cb Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano <gscrivan redhat com>
Date: Thu, 17 Mar 2016 13:10:40 +0100
Subject: [PATCH] docker-host: add runc

runc is a tool for spawning containers based on Open Container
Specifications.

Needed for: https://github.com/projectatomic/atomic/issues/298

Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
---
 fedora-atomic-docker-host.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fedora-atomic-docker-host.json b/fedora-atomic-docker-host.json
index b9f0342..c6bd5e9 100644
--- a/fedora-atomic-docker-host.json
+++ b/fedora-atomic-docker-host.json
@@ -75,7 +75,8 @@
 		 "python-docker-py",
 		 "iscsi-initiator-utils",
 		 "oddjob-mkhomedir",
-		 "atomic-devmode"],
+		 "atomic-devmode",
+		 "runc"],
 
     "default_target": "multi-user.target",
 
-- 
2.5.5