Re: [atomic-devel] GetCachedRebaseRpmDiff regression?

[Jonathan Lebon <jlebon redhat com>]

Hi Marius,

Thanks for the detailed report! If you don't mind, let's track this
upstream. I've opened [1] and copied your email in there.
Will investigate!

Thanks,

Jonathan

[1] https://github.com/projectatomic/rpm-ostree/issues/1250

On Wed, Feb 14, 2018 at 9:00 AM, Marius Vollmer
<marius vollmer redhat com> wrote:
> Hi,
>
> I think we have git some regression in rpm-ostreed on CentOS Atomic in
> our Cockpit integration tests:
>
>     https://bugs.centos.org/view.php?id=14493
>
> We found this when updating ou continuous-atomic image:
>
>     https://github.com/cockpit-project/cockpit/pull/8548
>     https://fedorapeople.org/groups/cockpit/logs/pull-8548-20180207-130707-8b3ca05f-verify-continuous-atomic/log.html
>
> I would like to make you guys aware of this straight away, in case it is
> something interesting for upstream.
>
> Basically, GetCachedRebaseRpmDiff now seems to return the wrong checksum
> and version.  Maybe this is caused by the way we construct our ostree
> test repositories.
>
>
> Reproducer steps dumped from the bug report:
>
>     mkdir -p /var/zrepo
>     mkdir -p /tmp/rpm-data/usr/share
>     cp -r /usr/share/rpm /tmp/rpm-data/usr/share/
>     ostree init --repo /var/zrepo --mode archive-z2
>     ostree commit --repo=/var/zrepo -b zremote-branch1 --orphan --tree=dir=/tmp/rpm-data --add-metadata-string version=zremote-branch1.1
>
>     ostree remote add zremote-test1 http://127.0.0.1:12345 --no-gpg-verify
>     rpm-ostree reload
>     <start a trivial webserver that serves /var/zrepo from http://127.0.0.1:12345>
>
>     # gdbus call -y -d org.projectatomic.rpmostree1 -o /org/projectatomic/rpmostree1/centos_atomic_host -m org.projectatomic.rpmostree1.OS.DownloadRebaseRpmDiff "zremote-test1:zremote-branch1" "[]"
>     # gdbus call -y -d org.projectatomic.rpmostree1 -o /org/projectatomic/rpmostree1/centos_atomic_host -m org.projectatomic.rpmostree1.OS.GetCachedRebaseRpmDiff "zremote-test1:zremote-branch1" "[]"
>     (@a(sua{sv}) [], {'osname': <'centos-atomic-host'>, 'timestamp': <uint64 1518611341>, 'origin': <'zremote-test1:zremote-branch1'>, 'checksum': <'6a5a02b7fe761338591c5a1e28963acbfb391bc50d3a1cd68c42974d34364ebc'>, 'gpg-enabled': <false>, 'version': <'cockpit-base.1'>})
>
>     # rpm-ostree status
>     State: idle; auto updates disabled
>     Deployments:
>     * ostree://local:centos-atomic-host/7/x86_64/devel/continuous
>                        Version: cockpit-base.1 (2018-02-14 12:29:01)
>                         Commit: 6a5a02b7fe761338591c5a1e28963acbfb391bc50d3a1cd68c42974d34364ebc
>
>       ostree://centos-atomic-continuous:centos-atomic-host/7/x86_64/devel/continuous
>                        Version: 7.2017.1026 (2018-02-05 16:09:11)
>                         Commit: e5e1d67af13843af97dec2774a00cb7ddf5857a413b1f2664b01b294eecf3585
>
> You can see that GetCachedRebaseRpmDiff returns the checksum of the
> current deployment instead of the one for zremote-test1:zremote-branch1.
>